Clarify username taken error message during registration#14
Open
TonyHeeee wants to merge 1 commit intoCMU-313:mainfrom
Open
Clarify username taken error message during registration#14TonyHeeee wants to merge 1 commit intoCMU-313:mainfrom
TonyHeeee wants to merge 1 commit intoCMU-313:mainfrom
Conversation
Pull Request Test Coverage Report for Build 21598710021Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR clarifies the error message shown during user registration when a chosen username
conflicts with an existing user or group.
Previously, the client-side validation displayed a generic "username taken" message, which
did not clearly indicate that group name conflicts are also checked. I changed the error message to better inform users of this error. This change improves user feedback by making the error message more accurate and reduces user confusion.
Changes
public/src/client/register.jsto use a clearer translation key when a usernameor group name conflict is detected during registration.
public/language/en-US/error.json.